ocaml-kafka: init at 0.4 #73584
Merged
ocaml-kafka: init at 0.4 #73584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
reviewed
Nov 21, 2019
|
|
||
| buildInputs = [ ocaml findlib dune base cmdliner ocaml_lwt rdkafka zlib ]; | ||
|
|
||
| propagatedBuildInputs = [ rdkafka zlib ]; |
There was a problem hiding this comment.
The libraries that appear in propagatedBuildInputs need not be duplicated in the buildInputs list.
|
Indeed, updated. Also found the doc about buildDunePackage. Nice! Thank you ! |
vbgl
reviewed
Nov 22, 2019
| sha256 = "0lb8x0wh7sf8v9mjwhq32azjz54kw49fsjfb7m76z4nhxfkjw5hy"; | ||
| }; | ||
|
|
||
| buildInputs = [ base cmdliner ocaml_lwt zlib ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ base cmdliner ocaml_lwt zlib ]; | |
| buildInputs = [ base cmdliner ocaml_lwt ]; |
|
@GrahamcOfBorg build ocamlPackages.kafka |
|
Hu, sorry, I'm moving house/country these days and had no time to look at this. Will be fully operational in a few more days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the kafka bindings to OCaml
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
that's me