device: Google Pixel 2 (non-XL) // google-walleye #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel build is technically the same as google-taimen, with some options switched around. An upcoming improvement will be to share the "wahoo" platform's kernel build with an option to switch between the two at build time, and further along the line, with modular kernels, sharing the same exact builds, but with the device-specifics as modules.
And related options.
3 tasks
|
Does this mean NixOS Mobile on Google Pixel 2 (non-XL) is stable? Should it be included in the device list? |
|
Sorry, no, it meant that 4 years ago there was tentative support added in hope that using vendor-based sources would be possible. Since then, with all that was learned, and how the overall ecosystem learned, it is obvious that it is a dead-end. See #643. To add support for any device, the device now needs to have some form of support either in mainline Linux, or in a mainline-adjacent "meant to go in mainline Linux" tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the port for the Google Pixel 2 (non-XL variant).
#38 can be rebased off of these changes. It should match, except for the kernel config, where these notes from the android-linux-stable project are relevant.
A common kernel solution will need to be figured out in the long run, but for now, this works.
It seems to work to parity with other devices... though sometimes the framebuffer doesn't seem to init right, but X11 always ends up starting. (Meaning that the Google bootloader logo sticks around for longer).
The next time I go around closing PRs I'll re-read this one, try to review it with a blank mind.