Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

displaylink: Disable free space check #73690

Merged
merged 1 commit into from Nov 19, 2019
Merged

displaylink: Disable free space check #73690

merged 1 commit into from Nov 19, 2019

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 18, 2019

The check fails if you have too much free disk space

Motivation for this change

Since #72858 replaces #67631, this one change is not done.
cc @nshalman

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dasJ
displaylink: Disable free space check
eba23da 
The check fails if you have too much free disk space
nshalman
nshalman approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@nshalman nshalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't have a way to trip that failure mode.

Lassulus
Lassulus approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lassulus Lassulus merged commit f7f1724 into NixOS:master Nov 19, 2019
@dasJ dasJ deleted the displaylink-diskcheck branch November 19, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshalman nshalman nshalman approved these changes

@Lassulus Lassulus Lassulus approved these changes

@abbradar abbradar Awaiting requested review from abbradar

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dasJ @nshalman @Lassulus