Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor.xilinx_*: Set IOB attribute on cells instead of nets. #272

Merged
merged 1 commit into from Nov 18, 2019
Merged

vendor.xilinx_*: Set IOB attribute on cells instead of nets. #272

merged 1 commit into from Nov 18, 2019

Conversation

jfng
Copy link
Contributor

@jfng jfng commented Nov 18, 2019

Fixes #263.

@whitequark
Copy link
Contributor

Is it not sufficient to use a_IOB=1 on the Instance for some reason?

@codecov
Copy link

codecov bot commented Nov 18, 2019 •
edited

Codecov Report

Merging #272 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   82.31%   82.31%           
=======================================
  Files          34       34           
  Lines        5598     5598           
  Branches     1201     1201           
=======================================
  Hits         4608     4608           
  Misses        850      850           
  Partials      140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c322e5...4dd1e01. Read the comment docs.

@jfng jfng changed the title xilinx_7series: Set IOB attribute on cells instead of nets. vendor.xilinx_*: Set IOB attribute on cells instead of nets. Nov 18, 2019
@whitequark
Copy link
Contributor

Thanks!

@whitequark whitequark merged commit f207f3f into m-labs:master Nov 18, 2019
@jfng jfng deleted the fix-iob-packing branch November 18, 2019 15:05
@nmigen-issue-migration nmigen-issue-migration mentioned this pull request Jan 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On Xilinx platforms, IOB should be set on the cell, not the net
2 participants
@jfng @whitequark