Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

croc: 6.2.3 -> 6.4.1 #73736

Merged
merged 1 commit into from Nov 19, 2019
Merged

croc: 6.2.3 -> 6.4.1 #73736

merged 1 commit into from Nov 19, 2019

Conversation

HugoReeves
Copy link
Member

@HugoReeves HugoReeves commented Nov 19, 2019 •
edited

Motivation for this change

Bump croc version to 6.4.1 see v6.4.1 release notes
NOTE: This is a breaking change, upstream croc does not strictly confirm with semver and the minor 2->4 change is breaking.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ self

@ofborg ofborg bot requested a review from kalbasit November 19, 2019 03:51
jonringer
jonringer approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73736
1 package were built:
croc

@jonringer
Copy link
Contributor

@GrahamcOfBorg build croc

@jonringer jonringer merged commit e8f1c6c into NixOS:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HugoReeves @jonringer