New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
device: Google Pixel 1 XL // google-marlin #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! 👋 Thanks for the amazing contribution!
This looks good. This changes so few things that this is almost ready to merge. Some minor changes as in-line comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the commented-out lines removed, this now looks almost ready to merge. Only one minor nitpick.
Can you split the commit as one for devices/google-marlin/default.nix
and the other for adding devices/google-marlin/kernel/*
?
Now. About USB gadget stuff: it's not only the Pixel 1. So this PR can be merged and the gadgetfs stuff figured out later. The Basically, affecting the Pixel 2, it looks like some devices will crash hard with some inputs, some are just fine with weird input in the gadgetfs... It looks like it's not going to be a one-size-fits-all solution, and it is good to have more devices using the new gadgetfs stuff in the project. If you want to look at the |
0b3650d
to
e566bf6
Compare
e566bf6
to
17e1529
Compare
17e1529
to
cbaa708
Compare
Thanks! |
@danielfullmer @samueldr I have a Google Pixel ( Would you be up for walking me through this? |
@samueldr and @danielfullmer helped me with this, and with PR #364 applied, the Google Pixel 1 ( |
WIP support for Pixel 1 XL.
Current status:
I believe this should work with the non-XL pixel 1 (google-sailfish) with a simple
s/marlin/sailfish/
+ changing the resolution, but I don't have one to test with.bootlog.txt
I'm currently having issues with bringing up the USB system. I believe the problem is a kernel crash when setting
/sys/class/android_usb/android0/enable
. This can be seen in the attached bootlog. The problem seems to be the line mentioningInternal error: Accessing user space memory outside uaccess.h routines:...
inffs_function_enable
. Just wondering if anyone else has encountered something similar.