-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake setup depends on users Python install #1155
Comments
If we remove conda setup from CMake completely, that will solve this problem. |
I'm leaning towards this approach. Moving the Python environment setup being separate and then the Cmake script checking for dependencies during configuration time? |
CMake just needs to know where the dependencies are located. By default it could use the conda deps, and override with the env var like before. |
I think step 1 is to propose a way to setup the environment that is different, but achieves the same goals. The current CMake-based environment method has 3 elements:
|
Relevant CMake functions:
|
After playing with stuff in the https://github.com/SymbiFlow/sphinxcontrib-verilog-diagrams repository I think the following could work. A conda environment configuration can be described with an
|
Some of the |
Apparently
|
So the key is whether there ever a case where a python library is both installed via pip and needs to be in |
The code at;
https://github.com/SymbiFlow/symbiflow-arch-defs/blob/a2fd4336208b05966cf05ad97daa8b455982ab8c/ice40/devices/layouts/icebox/CMakeLists.txt#L16-L25
depends on a user's Python install. This is unfortunate as the whole point of using conda is to provide a self contained python install which is isolated from the user's install.
The text was updated successfully, but these errors were encountered: