valgrind: Add perl as a native build input #73606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #67548 broke cross-compilation not for valgrind, but for
software relying on valgrind at build-time.
Motivation for this change
Building
libdrm
through cross-compilation fails.This is perl being interpreted by the shell (bash).
Bisecting points to d22b485 being the breaking change.
I am not 100% sure that adding perl to both kind of buildInputs is the solution, are there any drawbacks, or dangers to doing so?
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)cc @FRidh (who commented on the PR)
cc @Ericson2314 @matthewbauer (usual cross-compiling peeps)