network-manager: 1.20.4 -> 1.20.6 #73598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovesegfault
force-pushed
the
networkmanager-1.20.6
branch
from
421a713
to
d5ba79c
Compare
worldofpeace
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Thanks, and we for sure need this because iwd will be broken in networkmanager without it #72321
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/blob/1.20.6/NEWS#L9
|
@worldofpeace The bump came exactly because I saw someone bump iwd but not NM, and I use both :P |
|
While reviewing something else on staging I got: builder for '/nix/store/l438saam1469mjazfpv52awkk2fdvrpx-network-manager-1.20.6.drv' failed with exit code 1; last 10 log lines:
patching file src/nm-core-utils.c
applying patch /nix/store/s530j703x3rwc7c713f47khjch8d9wk4-fix-install-paths.patch
patching file meson.build
patching file src/settings/plugins/ifcfg-rh/meson.build
applying patch /nix/store/x0kw3z3xa0ym89cmiz41x2mzr0s3inmk-4c11364201c094ad19ab9980ea6051a82bd2a550.patch
patching file config.h.meson
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file config.h.meson.rejLooking at upstream config.h.meson for 1.20.6 it seems the patch fetched from Gitlab to solve #72330 is not needed anymore. |
|
@c0bw3b Will fix. My patch was merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
vbump
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @Phreedom @domenkozar @obadz