Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.blist: fix compatibility for python 3.7 19.09 backport #73603

Merged
merged 1 commit into from Nov 29, 2019
Merged

python37Packages.blist: fix compatibility for python 3.7 19.09 backport #73603

merged 1 commit into from Nov 29, 2019

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 18, 2019

Motivation for this change

Backports #73602 fixing https://hydra.nixos.org/build/106237840

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ahiaao ahiaao requested a review from FRidh as a code owner November 18, 2019 03:35
@ahiaao ahiaao changed the title python37Packages.blist: fix compatibility for python 3.7 python37Packages.blist: fix compatibility for python 3.7 19.09 backport Nov 18, 2019
@marsam marsam merged commit 6e966de into NixOS:release-19.09 Nov 29, 2019
@marsam
Copy link
Contributor

marsam commented Nov 29, 2019

Thanks!

@ahiaao ahiaao deleted the fix/blist-python37-backport branch February 18, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahiaao @marsam @FRidh @jonringer