Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cartopy: fix tests 19.09 backport #73607

Merged
merged 2 commits into from Nov 18, 2019
Merged

pythonPackages.cartopy: fix tests 19.09 backport #73607

merged 2 commits into from Nov 18, 2019

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 18, 2019

Motivation for this change

Backported #70671 to fix https://hydra.nixos.org/build/106235075

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mredaelli

@ahiaao ahiaao requested a review from FRidh as a code owner November 18, 2019 03:55
@ofborg ofborg bot requested a review from knedlsepp November 18, 2019 04:04
@jonringer
Copy link
Contributor

really kind of want to scrutinize this because it's essentially my changes... but I'll pass on that for now :)

jonringer
jonringer approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

[2 built, 63 copied (313.2 MiB), 71.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73607
1 package were build:
python37Packages.cartopy

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.cartopy

knedlsepp
knedlsepp approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@knedlsepp knedlsepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for backporting this

@jonringer jonringer merged commit 240381b into NixOS:release-19.09 Nov 18, 2019
@ahiaao ahiaao deleted the fix-cartopy-backport branch February 18, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knedlsepp knedlsepp knedlsepp approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahiaao @jonringer @knedlsepp