Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jellyfin: use FFmpeg 4 as recommended #73710

Merged
merged 1 commit into from Nov 19, 2019
Merged

jellyfin: use FFmpeg 4 as recommended #73710

merged 1 commit into from Nov 19, 2019

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 18, 2019 •
edited

Motivation for this change

The recommended version for FFmpeg is 4, as seen on startup of the service:

[WRN] FFmpeg validation: The minimum recommended ffmpeg version is 4.0
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nyanloutre @minijackson

minijackson
minijackson approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me ^^ (although I didn't test features that fully utilize ffmpeg, like live transcoding and hardware acceleration)

@etu
Copy link
Contributor

etu commented Nov 19, 2019

@GrahamcOfBorg test jellyfin

@etu etu merged commit d5966fd into NixOS:master Nov 19, 2019
@Moredread Moredread deleted the jellyfin-ffmpeg branch October 2, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minijackson minijackson minijackson approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @etu @minijackson