New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocamlPackages.printbox: 0.2 -> 0.4 #73705
Conversation
@@ -1,19 +1,19 @@ | |||
{ lib, fetchFromGitHub, buildDunePackage, ocaml, mdx }: | |||
{ lib, fetchFromGitHub, buildDunePackage, ocaml, mdx, uucp, uutf }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mdx
is no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed from the dependency list.
|
||
minimumOCamlVersion = "4.05"; | ||
|
||
src = fetchFromGitHub { | ||
owner = "c-cube"; | ||
repo = pname; | ||
rev = version; | ||
sha256 = "16nwwpp13hzlcm9xqfxc558afm3i5s802dkj69l9s2vp04lgms5n"; | ||
rev = "v${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change correct? Here is a URL from which the source can be fetched: https://github.com/c-cube/printbox/releases/download/0.3/printbox-0.3.tbz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the revision at upstream has changed after the PR was first written. Fixed now.
@@ -1,24 +1,24 @@ | |||
{ lib, fetchFromGitHub, buildDunePackage, ocaml, mdx }: | |||
{ lib, fetchFromGitHub, buildDunePackage, ocaml, uucp, uutf }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ lib, fetchFromGitHub, buildDunePackage, ocaml, uucp, uutf }: | |
{ lib, fetchFromGitHub, buildDunePackage, uucp, uutf }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@GrahamcOfBorg build ocamlPackages.printbox |
Motivation for this change
Update to version 0.4
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)