Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging: compiler-rt scudo compatibility #73766

Merged
merged 1 commit into from Nov 26, 2019
Merged

staging: compiler-rt scudo compatibility #73766

merged 1 commit into from Nov 26, 2019

Conversation

kmcopper
Copy link
Contributor

Motivation for this change

Forked from #73763 . Told to put this in staging due by @joachifm due the mass rebuild. I didn't fully test all the dependencies but it shouldn't break anything it's mostly a compatibility change.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323 @7c6f434c @dtzWill

@kmcopper kmcopper changed the title staging-next: compiler-rt compatibility staging: compiler-rt compatibility Nov 19, 2019
@kmcopper kmcopper mentioned this pull request Nov 19, 2019
Merged
9 tasks
@kmcopper kmcopper changed the title staging: compiler-rt compatibility staging: compiler-rt scudo compatibility Nov 19, 2019
matthewbauer
matthewbauer approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, scudo just works on Linux, but it looks like it doesn't hurt to have it elsewhere as well.

@joachifm joachifm merged commit 90f0868 into NixOS:staging Nov 26, 2019
@kmcopper kmcopper deleted the staging-compiler-rt branch November 26, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmcopper @matthewbauer @joachifm