Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim-unwrapped: 0.4.2 -> 0.4.3 #73749

Merged
merged 1 commit into from Dec 5, 2019
Merged

neovim-unwrapped: 0.4.2 -> 0.4.3 #73749

merged 1 commit into from Dec 5, 2019

Conversation

teto
Copy link
Member

@teto teto commented Nov 19, 2019 •
edited

Motivation for this change

released 3 days ago

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Nov 19, 2019

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from manveru November 19, 2019 14:03
@ghost
Copy link

ghost commented Nov 21, 2019

👍 sip ahhh, they don't make text editors like this anymore.

@teto
Copy link
Member Author

teto commented Dec 5, 2019

I've been using it (and master) without issue since then.

@teto teto merged commit 9c6ceb5 into NixOS:master Dec 5, 2019
@teto teto deleted the neovim_043 branch December 5, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manveru manveru Awaiting requested review from manveru

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @FRidh