I don't know why konsole was broken. It seems odd to me. Maybe the fix in the hook is not correct. Checking other KDE components now as well.

Adding dependencies like I did is I think the wrong way because most KDE applications are now broken. That has to be due to propagation or the hook.

I've pushed the hooks to staging-next.

Are these remaining changes set -u related?

Well, nothing else has changed anywhere close to KDE packaging as far as I can tell.

Bisecting with this large staging-next change is not going to be fun

@FRidh Or simplier put, what is the symptom this fixes, and how do I reproduce this on master today?

@Ericson2314 nix-build -A kdeApplications.konsole:

https://hydra.nixos.org/build/107199242/nixlog/1

git bisect points to 13bab29, perhaps the hookName should be properly escaped. Though I do not see how it is not a syntax error.

Yes, it's missing the ''. Did a successful build with that fixed.

Are you pushing the fix?

Should use [[ too as you will get a problem of too few args with empty string.

Also consider plain ${foo-} to rule out the URL possibility.

Having problems with kwin like

building '/nix/store/svr5q5q3i7ja9wv0d23brbs2bdcp092c-kwin-5.16.5.drv'...
/nix/store/mq2hcss5fc5g3127z22abpy0a3lk9zk0-breeze-qt5-5.16.5-dev/nix-support/setup-hook: line 5: propagatedUserEnvPkgs: unbound variable
builder for '/nix/store/svr5q5q3i7ja9wv0d23brbs2bdcp092c-kwin-5.16.5.drv' failed with exit code 1
error: build of '/nix/store/svr5q5q3i7ja9wv0d23brbs2bdcp092c-kwin-5.16.5.drv' failed

currently blocking the channel.

Well those responses were for the linked commits. This PR is fine; I still don't know why it became necessary, but the deep dives we've done into other issues didn't turn up fundimental problems, so I'll just let my lack of knowledge here slide.

this should not have gone in because these changes were not needed

Oh. I'm sorry, I thought they were. Should have remembered the WIP.

latest fix 646b279