Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openxray: make it work again #73753

Merged
merged 1 commit into from Nov 24, 2019
Merged

openxray: make it work again #73753

merged 1 commit into from Nov 24, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2019

Motivation for this change

Needed after #72199
See OpenXRay/xray-16#518

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Nov 19, 2019

Please add the meta information.

@ghost
Copy link
Author

ghost commented Nov 19, 2019

@FRidh to local cryptopp? Is that required? openxray is unfree and not built on hydra

@FRidh
Copy link
Member

FRidh commented Nov 19, 2019

indeed for cryptopp. Derivations should have meta information.

@ghost
Copy link
Author

ghost commented Nov 19, 2019

@FRidh Done

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to work

@Lassulus Lassulus merged commit c67d3f1 into NixOS:master Nov 24, 2019
@ghost
Copy link
Author

ghost commented Nov 24, 2019

@FRidh @Lassulus thanks!

@ghost ghost deleted the openxray branch November 24, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants