Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.10.8 -> 4.10.10 - security #73754

Merged
merged 1 commit into from Nov 19, 2019
Merged

samba: 4.10.8 -> 4.10.10 - security #73754

merged 1 commit into from Nov 19, 2019

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Nov 19, 2019 •
edited

Motivation for this change

Addresses issue: #73682
Samba fixes overview for reference:
https://www.samba.org/samba/history/security.html

This should be also backported to 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aneeshusa @dtzWill

@grahamc grahamc merged commit 93e8c34 into NixOS:master Nov 19, 2019
@grahamc
Copy link
Member

grahamc commented Nov 19, 2019

Can you send a backport PR? with git cherry-pick -x.

@d-goldin d-goldin mentioned this pull request Nov 19, 2019
Closed
10 tasks
@d-goldin
Copy link
Contributor Author

@grahamc: Will do.

@d-goldin d-goldin mentioned this pull request Nov 19, 2019
Merged
10 tasks
@d-goldin d-goldin deleted the samba_update_security_fixes branch November 19, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-goldin @grahamc