Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-manager: 2019-10-29 -> 2019-11-17 #73611

Merged
merged 1 commit into from Nov 18, 2019
Merged

home-manager: 2019-10-29 -> 2019-11-17 #73611

merged 1 commit into from Nov 18, 2019

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 18, 2019 •
edited

Motivation for this change

The lorri module was recently added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@timokau
home-manager: 2019-10-29 -> 2019-11-17
bee1fa9 
The lorri module was recently added.
@ofborg ofborg bot requested a review from rycee November 18, 2019 07:51
@timokau timokau merged commit c0a56ee into NixOS:master Nov 18, 2019
@timokau timokau deleted the home-manager-2019-11-17 branch November 18, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@timokau