Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cmd2: 0.19.0 -> 0.20.0 #73745

Merged
merged 1 commit into from Nov 19, 2019
Merged

python3Packages.cmd2: 0.19.0 -> 0.20.0 #73745

merged 1 commit into from Nov 19, 2019

Conversation

teto
Copy link
Member

@teto teto commented Nov 19, 2019

Motivation for this change

https://github.com/python-cmd2/cmd2/blob/master/CHANGELOG.md

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@teto
Copy link
Member Author

teto commented Nov 19, 2019

@GrahamcOfBorg build python3Packages.cmd2

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commits LGTM

[4 built (1 failed), 51 copied (620.3 MiB), 95.2 MiB DL]
error: build of '/nix/store/8ghk0r8055hzzmpdqgxvs4c2giway83c-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/73745
1 package failed to build:
python37Packages.optuna

4 package were build:
python37Packages.cliff python37Packages.cmd2 python38Packages.cliff python38Packages.cmd2

@jonringer jonringer merged commit 56b5f66 into NixOS:master Nov 19, 2019
@teto teto deleted the cmd2 branch November 19, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants