Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macvim: Add -headerpad_max_install_names #73592

Merged
merged 1 commit into from Nov 18, 2019
Merged

macvim: Add -headerpad_max_install_names #73592

merged 1 commit into from Nov 18, 2019

Conversation

lilyball
Copy link
Member

Motivation for this change

We were adding this to the compilation of MacVim, but not to the compilation of the separate Vim binary. We may not actually need it for MacVim at all, but omitting it for the Vim binary meant our postInstall phase would fail for some people.

Fixes #73514

Things done
  • Tested using sandboxing - relaxed sandbox
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I didn't reproduce the build failure in the first place, but I expect this to fix it.

@lilyball
macvim: Add -headerpad_max_install_names
e9d1262 
We were adding this to the compilation of MacVim, but not to the
compilation of the separate Vim binary. We may not actually need it for
MacVim at all, but omitting it for the Vim binary meant our postInstall
phase would fail for some people.

Fixes NixOS#73514
@lilyball lilyball mentioned this pull request Nov 18, 2019
Closed
@ofborg ofborg bot added the 6.topic: vim label Nov 18, 2019
@veprbl veprbl added the 6.topic: darwin Running or building packages on Darwin label Nov 18, 2019
@veprbl veprbl merged commit 505f913 into NixOS:master Nov 18, 2019
@veprbl
Copy link
Member

veprbl commented Nov 18, 2019

@lilyball Thank you for the fix. Does this need a backport?

@lilyball
Copy link
Member Author

lilyball commented Nov 18, 2019 via email

veprbl pushed a commit that referenced this pull request Nov 18, 2019
@lilyball @veprbl
macvim: Add -headerpad_max_install_names (#73592)
5f506b9 
We were adding this to the compilation of MacVim, but not to the
compilation of the separate Vim binary. We may not actually need it for
MacVim at all, but omitting it for the Vim binary meant our postInstall
phase would fail for some people.

Fixes #73514

(cherry picked from commit 505f913)
@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Nov 18, 2019
@lilyball lilyball deleted the macvim-headerpad branch November 18, 2019 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: vim 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macvim fails to install
2 participants
@lilyball @veprbl