Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r19.09] ghostscript: add patches for CVE-2019-3835, CVE-2019-3838, CVE-2019-14869 #73590

Merged

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Nov 18, 2019

Motivation for this change

This was originally aimed at just fixing https://nvd.nist.gov/vuln/detail/CVE-2019-14869 as a backport of #73500, the patch of course needed some adjustment and also appeared to depend on some changes made in previous commits. The answer came from debian's 9.26a~dfsg-0+deb9u6, which has an appropriately adjusted, though not well labeled, patch series. Unfortunately I couldn't find any online source that actually hosted these individual files. Not https://sources.debian.org, not https://salsa.debian.org/printing-team/ghostscript - so I had to include the files hand-extracted from the source package, leaving them verbatim to acknowledge their source.

The bonus was that this patch series also included adjusted patches for CVE-2019-3835 & CVE-2019-3838, which had previously been unpatched. Though it was a royal pain in the ass determining exactly the role of each patch in their series and which were totally necessary...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

context-adjusted patches cribbed from debian's 9.26a~dfsg-0+deb9u6, also
requiring further adjustment of patch for CVE-2019-10216
again, context-adjusted patches cribbed from debian's 9.26a~dfsg-0+deb9u6
again, context-adjusted patch cribbed from debian's 9.26a~dfsg-0+deb9u6
@risicle
Copy link
Contributor Author

risicle commented Nov 18, 2019

@GrahamcOfBorg build pstoedit evince

@FRidh FRidh added this to Needs review in Staging (stable) Nov 19, 2019
@FRidh FRidh merged commit 0fba5b9 into NixOS:staging-19.09 Dec 1, 2019
Staging (stable) automation moved this from Needs review to Done Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants