Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MySQL Include Path #73593

Closed
wants to merge 10 commits into from
Closed

Fix MySQL Include Path #73593

wants to merge 10 commits into from

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 18, 2019

Motivation for this change

Fixes https://hydra.nixos.org/build/106233951

I noticed several other packages had the same error so I corrected them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mpickering @juliendehos @orivej @peterhoeg @4z3 @rickynils @globin @fare @thoughtpolice @sheganinans

@aanderse
Copy link
Member

cc @Izorkin

@Izorkin
Copy link
Contributor

Izorkin commented Nov 19, 2019

Thanks for fix.
My fix variant grass - https://github.com/NixOS/nixpkgs/pull/72876/files
Other packages in 19.09 did not check.

@Izorkin
Copy link
Contributor

Izorkin commented Nov 19, 2019

In the master branch, these packages correct builded.

@bennofs
Copy link
Contributor

bennofs commented Jan 24, 2020

merged to the release branch.

@bennofs bennofs closed this Jan 24, 2020
@bennofs bennofs mentioned this pull request Jan 24, 2020
Closed
10 tasks
@ahiaao ahiaao deleted the fix/mysql-include-path branch February 18, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahiaao @aanderse @Izorkin @bennofs