Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jack2: 1.9.13 -> 1.9.14, fix build arm #73779

Merged
merged 1 commit into from Nov 19, 2019
Merged

jack2: 1.9.13 -> 1.9.14, fix build arm #73779

merged 1 commit into from Nov 19, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

See: https://github.com/jackaudio/jack2/releases/tag/v1.9.14

Thanks for fedora working on python3 there and the arm patch 馃挅.

I've opened this PR because I noticed that geary was failing to build on aarch64 (and thusly the gnome3 tests).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
jack2: 1.9.13 -> 1.9.14, fix build arm
61d1338 
See: https://github.com/jackaudio/jack2/releases/tag/v1.9.14

Thanks for fedora working on python3 there and the arm patch 馃挅.
@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build libjack2

(need to check lib only also builds)

@worldofpeace worldofpeace mentioned this pull request Nov 19, 2019
Closed
@worldofpeace worldofpeace merged commit 504094d into NixOS:master Nov 19, 2019
@worldofpeace worldofpeace deleted the jack2-arm-fix-build branch November 19, 2019 22:22
@worldofpeace
Copy link
Contributor Author

umm, mass rebuild 馃ぃ

Merged to staging a20dd95, revert on master 041d35a

@thefloweringash thefloweringash mentioned this pull request Nov 24, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace