Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brotab: init at 0.0.5 #73777

Merged
merged 2 commits into from Feb 11, 2020
Merged

brotab: init at 0.0.5 #73777

merged 2 commits into from Feb 11, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Nov 19, 2019 •
edited

Motivation for this change

Browser tab controller - https://github.com/balta2ar/brotab

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

jonringer
jonringer reviewed Nov 19, 2019
View reviewed changes
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/brotab/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@doronbehar
Copy link
Contributor Author

Thanks for the comments @jonringer !

jonringer
jonringer reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo seems to be most a 1 person show with no other repositories currently packaging this.

Why should ilt be added to nixpkgs?

pkgs/tools/misc/brotab/default.nix Show resolved Hide resolved
@doronbehar
Copy link
Contributor Author

doronbehar commented Nov 20, 2019 •
edited

Why should ilt be added to nixpkgs?

Well first of all, the fact it's not famous enough so that other repos will include it doesn't mean the package is not useful. The least I can in order to support this software is to distribute it, starting with NixOS.

Besides that, it's not just a script that one can git clone and link to his $PATH - the package consists of several executables the browser extension needs to be aware of. Hence it's almost impossible for NixOS users to use it without installing it the Nix way. EDIT: see balta2ar/brotab#7

@doronbehar
Copy link
Contributor Author

What say you @jonringer ?

@doronbehar doronbehar force-pushed the package-brotab branch 2 times, most recently from 328289a to df17bf6 Compare January 8, 2020 12:11
@doronbehar @jonringer
Add checkPhase
d9935b1 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
jonringer
jonringer approved these changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73777
1 package built:
brotab

@jonringer
Copy link
Contributor

@GrahamcOfBorg build brotab

@JohnAZoidberg
Copy link
Member

JohnAZoidberg commented Feb 11, 2020 •
edited

This is actually a pretty cool tool!
Let's see how helpful it is for managing my 500+ tabs :P

@JohnAZoidberg JohnAZoidberg merged commit 8cc8b3b into NixOS:master Feb 11, 2020
@doronbehar
Copy link
Contributor Author

Thanks! 😄

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 12, 2020
@JohnAZoidberg @dtzWill
Merge pull request NixOS#73777 from doronbehar/package-brotab
ed69965 
brotab: init at 0.0.5
(cherry picked from commit 8cc8b3b)
@doronbehar doronbehar deleted the package-brotab branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @jonringer @JohnAZoidberg