Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thonny: 3.2.0b7 -> 3.2.3 #73778

Merged
merged 1 commit into from Nov 19, 2019
Merged

thonny: 3.2.0b7 -> 3.2.3 #73778

merged 1 commit into from Nov 19, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Nov 19, 2019

Motivation for this change

Update to version 3.2.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

redvers
redvers approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@redvers redvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[X] reviewed the diff and commit messages
[X] made sure ofBorg build succeeded for all applicable platforms
[X] run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)

Looks like a simple version bump. Added a propagatedBuildInput which seemed reasonable.

@redvers
Copy link
Member

redvers commented Nov 19, 2019

Added a review.

Paging @leenaars

jonringer
jonringer approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
commit LGTM
gui launches fine

[3 built, 2 copied (0.1 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73778
1 package were built:
thonny

@jonringer jonringer merged commit b026faf into NixOS:master Nov 19, 2019
@romildo romildo deleted the upd.thonny branch November 19, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redvers redvers redvers approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romildo @redvers @jonringer