Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastjet-contrib: init at 1.042 #73716

Merged
merged 1 commit into from Nov 19, 2019
Merged

fastjet-contrib: init at 1.042 #73716

merged 1 commit into from Nov 19, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 18, 2019 •
edited

Motivation for this change

Upcoming bump for rivet to version 3.0.2 requires fastjet-contrib as a new dependency.

The "fragile-shared" targets use used to enable build of a shared library. Additional "make" call were added in postBuild and postInstall because standard stdenv's features like installTarget would not work with these makefiles because "fragile-shared" targets are available in the main makefile, but not in submakefiles, so we can't build those when recursion is taking place.

Things done
Notify maintainers

cc @

jonringer
jonringer approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
outputs LGTM

[3 built, 1 copied (5.5 MiB), 0.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73716
1 package were built:
fastjet-contrib

@jonringer jonringer merged commit 3ff2360 into NixOS:master Nov 19, 2019
@veprbl veprbl deleted the pr/fastjet-contrib_init branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @jonringer