Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-curator: move out of python-packages #73717

Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 18, 2019

Motivation for this change

Upstream froze click to <7, which means it will only
work with overrides, which means it can't compose
with other python modules.

previously, this was just broken when trying to build as pythonXPackages.elasticsearch-curator, and only the application worked because it overrided the version of click

partially resolves #68587

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73717
1 package were build:
elasticsearch-curator

Upstream froze click to <7, which means it will only
work with overrides, which means it can't compose
with other python modules.
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg test elk

@jonringer jonringer merged commit 6a983b6 into NixOS:master Nov 19, 2019
@jonringer jonringer deleted the move-elastic-curator-out-of-python-modules branch November 19, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can we deprecate pyyaml_3?
2 participants