Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zsh-syntax-highlighting: backport Fix highlighting when ohMyZsh is enabled #73695

Closed
wants to merge 1 commit into from
Closed

nixos/zsh-syntax-highlighting: backport Fix highlighting when ohMyZsh is enabled #73695

wants to merge 1 commit into from

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Nov 18, 2019

Motivation for this change

Backport zsh-syntax-highlighting initialization order fix.

Fixes: #73386

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @AIDEA775

@AIDEA775 @B4dM4n
nixos/zsh-syntax-highlighting: Fix highlighting when ohMyZsh is enabled
2cf304a 
From https://github.com/zsh-users/zsh-syntax-highlighting#faq:

"It must be sourced after all custom widgets have been created
(i.e., after all zle -N calls and after running compinit)."

zsh-syntax-highlighting must be sourced to the end.
@AIDEA775
Copy link
Contributor

Would be nice!

@infinisil
Copy link
Member

In the future you should make backport PR's to the release-19.09 branch instead. For now I backported that commit in #71825 (comment)

@infinisil infinisil closed this Jan 16, 2020
@B4dM4n B4dM4n deleted the zsh-syntax-highlighting-backport branch January 16, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @AIDEA775 @infinisil