zplugin:init at 2.3 #73764

pasqui23 · 2019-11-19T15:42:24Z

Motivation for this change

Things done

Building fails with

nix-env -f ./. -iA zplugin
installing 'zplugin-2.3'
these derivations will be built:
  /nix/store/sanj1x0ishjzrqbpkwhpmwr41hl2j6vn-zplugin-2.3.drv
building '/nix/store/sanj1x0ishjzrqbpkwhpmwr41hl2j6vn-zplugin-2.3.drv'...
unpacking sources
unpacking source archive /nix/store/wl0pvhglyvkyvny2hgjvgyn0bi89ilnr-source
source root is source
patching sources
configuring
no configure script, doing nothing
installing
/nix/store/npsin1jlnzs5sqxpsv2mk5gbnm4hk4kr-stdenv-linux/setup: eval: line 1337: unexpected EOF while looking for matching `"'
builder for '/nix/store/sanj1x0ishjzrqbpkwhpmwr41hl2j6vn-zplugin-2.3.drv' failed with exit code 2
error: build of '/nix/store/sanj1x0ishjzrqbpkwhpmwr41hl2j6vn-zplugin-2.3.drv' failed

Notify maintainers

cc @

pkgs/shells/zsh/zplugin/default.nix

jonringer · 2019-11-19T21:28:59Z

@GrahamcOfBorg eval

jonringer · 2019-11-19T21:31:10Z

pkgs/shells/zsh/zplugin/default.nix

+  #TODO:doc output
+
+  meta = with lib; {
+    license = licenses.mit;


license is listed twice

Suggested change

license = licenses.mit;

pkgs/shells/zsh/zplugin/default.nix

pasqui23 · 2019-11-24T14:16:25Z

What is the exact procedure for proposing as mantainer?

jonringer · 2019-11-24T18:19:25Z

it's pretty relaxed in nixpkgs, the main qualification is just general interest in the package. Most of the time, maintainers know how to use the software so they can verify that updates to it don't break any workflows.

little-dude · 2020-01-07T14:21:58Z

@pasqui23 do you plan to push this forward? Otherwise I might try to pick it up.

pasqui23 · 2020-01-08T01:33:37Z

So apparently it builds with the latest code

pasqui23 · 2020-01-08T01:34:56Z

@little-dude yes,I still want to push it

jonringer

you could also use install -DmXXX [sources] -t dest to greatly simplify a lot of this installation logic (it will create parent directories for you)

jonringer · 2020-01-08T03:00:05Z

pkgs/shells/zsh/zplugin/default.nix

+{ stdenvNoCC, lib, fetchFromGitHub }:
+stdenvNoCC.mkDerivation rec {
+  pname = "zplugin";
+  version = "2.3";


Suggested change

version = "2.3";

version = "2.3";

jonringer · 2020-01-08T03:00:10Z

pkgs/shells/zsh/zplugin/default.nix

@@ -0,0 +1,40 @@
+{ stdenvNoCC, lib, fetchFromGitHub }:


Suggested change

{ stdenvNoCC, lib, fetchFromGitHub }:

{ stdenvNoCC, lib, fetchFromGitHub }:

pkgs/shells/zsh/zplugin/default.nix

jonringer

sorry, forgot to add that installShellCompletion is another "package", so it needs to be added to avoid:

/nix/store/plcn9z5lzjd9lhij1cj73k2nwxkng4rq-stdenv-linux/setup: line 1309: installShellCompletion: command not found

jonringer · 2020-01-09T00:13:23Z

pkgs/shells/zsh/zplugin/default.nix

+    repo = pname;
+    rev = "v${version}";
+    sha256 = "0qqv5p19s8jb06d6h55dm4acji9x2rpxb2ni3h7fb0q43iz6y85w";
+  };


Suggested change

};

};

nativeBuildInputs = [ installShellCompletion ];

jonringer · 2020-01-09T00:13:29Z

pkgs/shells/zsh/zplugin/default.nix

@@ -0,0 +1,39 @@
+{ stdenvNoCC, lib, fetchFromGitHub }:


Suggested change

{ stdenvNoCC, lib, fetchFromGitHub }:

{ stdenvNoCC, lib, fetchFromGitHub, installShellCompletion }:

jonringer · 2020-01-09T00:16:58Z

don't forget to squash the commits, to squash the last 6 commits into the first you can do:

git reset HEAD~5 # put the last 5 changes into unstaged
git add pkgs/
git commit --amend --no-edit # amend into previous commit
git push <fork> <branch> --force

for other incremental changes into the last commit, you can just do:

git add pkgs/
git commit --amend --no-edit # amend into previous commit
git push <fork> <branch> --force

jonringer · 2020-01-09T02:14:26Z

pkgs/shells/zsh/zplugin/default.nix

+
+    # Zplugin-module files
+    find zmodules/ -type d -exec install -dm 755 "{}" "$outdir/{}" \;
+    find zmodules/ -type f -exec install -m 744 "{}" "$outdir/{}" \;


should this preserve the same file structure?

Suggested change

find zmodules/ -type f -exec install -m 744 "{}" "$outdir/{}" \;

find zmodules/ -type f -exec install -m 744 "{}" "$outdir/zmodules/{}" \;

Honestly now that I look it better,it seem it would be better if packaged separately

nixos-discourse · 2020-06-09T15:18:58Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/179

wmertens

Triage: lgtm but wondering about the native inputs @jonringer mentioned, should they be merged with the one on line 13?

jonringer

please resolve conflicts as well :)

jonringer · 2020-06-13T22:08:34Z

maintainers/maintainer-list.nix

+  pasqui23 = {
+    email = "p3dimaria@hotmail.it";
+    github = "pasqui23";
+    githubId = 6931743;
+  };


Please add your name.

Please make this into a separate commit:

maintainers: add <name>

pasqui23 · 2020-06-14T11:36:49Z

Closing in favor of #90322 @jonringer

jonringer reviewed Nov 19, 2019

View reviewed changes

pkgs/shells/zsh/zplugin/default.nix Outdated Show resolved Hide resolved

jonringer reviewed Nov 19, 2019

View reviewed changes

pasqui23 changed the title ~~[WIP]zplugin:init at 2.3~~ zplugin:init at 2.3 Jan 8, 2020

pasqui23 marked this pull request as ready for review January 8, 2020 01:34

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jan 8, 2020

jonringer reviewed Jan 8, 2020

View reviewed changes

jonringer reviewed Jan 9, 2020

View reviewed changes

pasqui23 force-pushed the zplg branch 2 times, most recently from f5c42a7 to 04bf131 Compare January 9, 2020 02:02

jonringer reviewed Jan 9, 2020

View reviewed changes

[WIP]zplugin:init at 2.3

e949b27

pasqui23 force-pushed the zplg branch from 04bf131 to e949b27 Compare January 9, 2020 17:09

wmertens reviewed Jun 13, 2020

View reviewed changes

jonringer reviewed Jun 13, 2020

View reviewed changes

pasqui23 closed this Jun 14, 2020

pasqui23 deleted the zplg branch June 14, 2020 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zplugin:init at 2.3 #73764

zplugin:init at 2.3 #73764

pasqui23 commented Nov 19, 2019 •

edited

jonringer commented Nov 19, 2019

jonringer Nov 19, 2019

pasqui23 commented Nov 24, 2019

jonringer commented Nov 24, 2019

little-dude commented Jan 7, 2020

pasqui23 commented Jan 8, 2020

pasqui23 commented Jan 8, 2020

jonringer left a comment

jonringer Jan 8, 2020

jonringer Jan 8, 2020

jonringer left a comment

jonringer Jan 9, 2020

jonringer Jan 9, 2020

jonringer commented Jan 9, 2020

jonringer Jan 9, 2020

pasqui23 Jan 9, 2020

nixos-discourse commented Jun 9, 2020

wmertens left a comment

jonringer left a comment

jonringer Jun 13, 2020

pasqui23 commented Jun 14, 2020

	{ stdenvNoCC, lib, fetchFromGitHub }:
	{ stdenvNoCC, lib, fetchFromGitHub }:

-  };
+  };
+  nativeBuildInputs = [ installShellCompletion ];

	{ stdenvNoCC, lib, fetchFromGitHub }:
	{ stdenvNoCC, lib, fetchFromGitHub, installShellCompletion }:

	find zmodules/ -type f -exec install -m 744 "{}" "$outdir/{}" \;
	find zmodules/ -type f -exec install -m 744 "{}" "$outdir/zmodules/{}" \;

zplugin:init at 2.3 #73764

zplugin:init at 2.3 #73764

Conversation

pasqui23 commented Nov 19, 2019 • edited

Motivation for this change

Things done

Notify maintainers

jonringer commented Nov 19, 2019

Choose a reason for hiding this comment

pasqui23 commented Nov 24, 2019

jonringer commented Nov 24, 2019

little-dude commented Jan 7, 2020

pasqui23 commented Jan 8, 2020

pasqui23 commented Jan 8, 2020

jonringer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonringer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonringer commented Jan 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nixos-discourse commented Jun 9, 2020

wmertens left a comment

Choose a reason for hiding this comment

jonringer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pasqui23 commented Jun 14, 2020

pasqui23 commented Nov 19, 2019 •

edited