New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skypeforlinux: Adding archive.org mirror #73771
Conversation
Adding an additional web-archive url to avoid breakage when old versions disappear from upstream. Still keeping original location to not needlessly hit archive.org (it's also slower).
urls = [ | ||
"https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_${version}_amd64.deb" | ||
"https://web.archive.org/web/https://repo.skype.com/deb/pool/main/s/skypeforlinux/skypeforlinux_${version}_amd64.deb" | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no trouble with this PR. I wonder how Archive.org feels about following the license of Skype, which I assume says you can't redistribute it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some precedent for using this approach in #70155 and a few other places for unreliable upstreams. But yes, indeed the big question remains, what does this actually mean in legal terms for archive.org. Maybe @fpletz knows sth.
In general, longer term, I'd almost prefer if we would move out a lot of those nastier non-free things in some way that still allows the users to use nix to install it, but versions and urls and what not would not sth that we manage in the core repo (like NUR/flakes). Because otherwise either we keep chasing versions or deal with what we see here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From ToS (https://www.skype.com/en/legal/ios/tos/ relevant section 4):
For the avoidance of doubt, (a) IT administrators working on behalf of a company may download and install the Skype Software onto personal computers or other devices used by personnel of such company; and (b) you are permitted to use the Software at a university or other educational institution, or at work. Skype reserves all rights not expressly granted to you under these Terms.
Applying not-lawyer-reasoning, apt-mirrors would be at least fine until those terms.
Once this has been clarified / cleared, I will provide a backport for r19.09. |
I have no concern around merging this and backporting it, I don't think we need to worry about Archive.org's concerns :) |
Motivation for this change
Addresses: #73597
Adding an additional web-archive url to avoid breakage when
old versions disappear from upstream. Still keeping original location
to not needlessly hit archive.org (it's also slower).
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @PanAeon @jraygauthier
@jamescostian