Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glowing-bear: 0.7.1 -> 0.7.2 #73770

Merged
merged 1 commit into from Nov 19, 2019
Merged

glowing-bear: 0.7.1 -> 0.7.2 #73770

merged 1 commit into from Nov 19, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 19, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from delroth November 19, 2019 17:08
jonringer
jonringer approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM

no idea how to test

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73770
1 package were built:
glowing-bear

delroth
delroth approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my IRC machine, 0.7.2 still seems to work fine. LGTM.

@delroth
Copy link
Contributor

delroth commented Nov 19, 2019

(To do some basic testing, you can literally just map the package dir into an nginx vhost, it's a static webapp.)

@jonringer jonringer merged commit 1003613 into NixOS:master Nov 19, 2019
@Mic92 Mic92 deleted the glowing-bear branch November 19, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @delroth @jonringer