Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dante: fix package under Linux #73746

Merged
merged 1 commit into from Jan 12, 2020
Merged

dante: fix package under Linux #73746

merged 1 commit into from Jan 12, 2020

Conversation

Shados
Copy link
Member

@Shados Shados commented Nov 19, 2019

Motivation for this change

Fixes #73697 and this issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nloomans
Copy link
Contributor

Anything keeping this from being merged? Building aerc from this branch fixes the socksify: error: dante client not built with preloading support. error I'm getting when opening text/html email.

nloomans
nloomans approved these changes Jan 12, 2020
View reviewed changes
Copy link
Contributor

@nloomans nloomans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this package following the https://discourse.nixos.org/t/prs-already-reviewed/2617/1 guide.

nixpkgs-review pr 73746 returned no errors and text/html emails work.

[x] reviewed the diff and commit messages
[x] made sure ofBorg build succeeded for all applicable platforms
[x] run nix-review for a reasonable amount of time without any failures (or marked preexisting failures as broken)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/83

@markuskowa
Copy link
Member

@GrahamcOfBorg build dante

markuskowa
markuskowa approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry misread the problem

@markuskowa markuskowa merged commit 26a4e0e into NixOS:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nloomans nloomans nloomans approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dante: client not built with preloading support.
4 participants
@Shados @nloomans @nixos-discourse @markuskowa