Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitlbee: fixing test-suite for newer libcheck #73752

Merged
merged 1 commit into from Nov 19, 2019
Merged

bitlbee: fixing test-suite for newer libcheck #73752

merged 1 commit into from Nov 19, 2019

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Nov 19, 2019 •
edited by veprbl

Motivation for this change

Fixes: #73747

After an update to libcheck from 0.12 to 0.13 the way bitlbee tests have been written
stopped working. I opened an upstream PR for this: bitlbee/bitlbee#140.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @pSub @terlar

Br1ght0ne
Br1ght0ne approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked with nix-review. Built and working fine.

Great job, just wanted to do this myself. Thanks a lot!

@ofborg ofborg bot requested a review from pSub November 19, 2019 13:21
@veprbl veprbl merged commit 2d55135 into NixOS:master Nov 19, 2019
@d-goldin d-goldin deleted the bitlbee_libcheck branch November 19, 2019 19:45
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 19, 2019
@d-goldin @dtzWill
bitlbee: fixing test-suite for newer libcheck (NixOS#73752)
bb59672 
Fixes: NixOS#73747
(cherry picked from commit 2d55135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bitlbee does not build
3 participants
@d-goldin @Br1ght0ne @veprbl