Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-sodium: init at 0.6.0 #73713

Merged
merged 1 commit into from Nov 22, 2019
Merged

ocaml-sodium: init at 0.6.0 #73713

merged 1 commit into from Nov 22, 2019

Conversation

rixed
Copy link
Contributor

@rixed rixed commented Nov 18, 2019

Motivation for this change

Trivial packaging of the libsodium bindings for OCaml, that I need for a less trivial one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vbgl
Copy link
Contributor

vbgl commented Nov 20, 2019

@GrahamcOfBorg build ocamlPackages.sodium

@vbgl
Copy link
Contributor

vbgl commented Nov 20, 2019

May you have a look at the build failure on darwin? It’s probably related to hardening, that you may disable on that platform (see: https://nixos.org/nixpkgs/manual/#sec-hardening-in-nixpkgs). Maybe something like:

hardeningDisable = stdenv.lib.optional stdenv.isDarwin "strictoverflow";

@rixed
Copy link
Contributor Author

rixed commented Nov 21, 2019

Indeed I had an error on macos:

clang-7: error: argument unused during compilation: '-fno-strict-overflow'

And the suggested change fixes it.
Stupid question I know, but how did you know? I couldn't see on the PR page any mention of a failed build.

@vbgl
Copy link
Contributor

vbgl commented Nov 22, 2019

@GrahamcOfBorg build ocamlPackages.sodium

@vbgl vbgl merged commit 359e644 into NixOS:master Nov 22, 2019
@vbgl
Copy link
Contributor

vbgl commented Nov 22, 2019

Here is a failing build, triggered by my first comment: https://logs.nix.ci/?attempt_id=4f3cddf4-63c3-467d-b4af-3dbdb8c85531&key=nixos%2Fnixpkgs.73713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants