Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jemalloc450: disable transparent huge pages on ARM #68335

Merged
merged 1 commit into from Sep 9, 2019
Merged

jemalloc450: disable transparent huge pages on ARM #68335

merged 1 commit into from Sep 9, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

The bug I fixed in #33260 has returned now that we have a jemalloc 4 package again. This PR adds back the necessary flags to get jemalloc 4 to compile on 32-bit ARM.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @yorickvP because you added jemalloc 4.5.0

@Mic92 Mic92 merged commit 4d6a6fe into NixOS:master Sep 9, 2019
@lopsided98 lopsided98 deleted the jemalloc450-disable-thp branch September 9, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @Mic92