Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity, parity-beta: update cargoSha256 hashes #68336

Merged
merged 2 commits into from Sep 9, 2019
Merged

parity, parity-beta: update cargoSha256 hashes #68336

merged 2 commits into from Sep 9, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Sep 9, 2019

Motivation for this change

Update cargoSha256 hashes for parity and parity-beta

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @akru

@xrelkd
Copy link
Contributor Author

xrelkd commented Sep 9, 2019

@GrahamcOfBorg build parity parity-beta

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build parity parity-beta

@worldofpeace
Copy link
Contributor

I think something is up with ofborg... I'll build this locally.

worldofpeace
worldofpeace approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine on NixOS.

@worldofpeace worldofpeace merged commit 137a90c into NixOS:master Sep 9, 2019
@xrelkd
Copy link
Contributor Author

xrelkd commented Sep 9, 2019

@worldofpeace @akru Thank you!!

@xrelkd xrelkd deleted the update/parity branch September 9, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akru akru akru approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @worldofpeace @akru