New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next with systemd 243 #68339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linux-kernel: HID_BATTERY_STRENGTH=yes
…atch With systemd version 243 network units with empty match block will generate warnigs. The reasoning seems to be that the intended behaviour is hard to infere. Being explicit about really meaning any interface is the reasonable thing here. We want to get rid of this mechanism in the long run but as long as we do not have a replacement we should stick with it and keep it in reasonable good shape.
It turned out that /dev/snd/* always exists even if there are no sound drivers loaded at all. Loading `snd` and `snd_timer` fixes that situation. It is probably fair to assume someone that wants to use sound also enables that in the NixOS configuration.
systemd: 242 -> 243
treewide: remove redundant quotes
FRidh
requested review from
adisbladis,
alyssais,
peti and
zimbatm
as code owners
September 9, 2019 06:15
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
6.topic: python
labels
Sep 9, 2019
ofborg
bot
added
6.topic: ruby
6.topic: vim
8.has: documentation
8.has: module (update)
labels
Sep 9, 2019
This cycle causes another 12.000 builds which is not that many. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
6.topic: python
6.topic: ruby
6.topic: vim
8.has: documentation
8.has: module (update)
10.rebuild-darwin: 501-1000
10.rebuild-darwin: 501+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @