Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trousers to latest, use regular openssl #68338

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Update trousers to latest, use regular openssl #68338

merged 2 commits into from
Nov 11, 2019
+8 −15

Conversation

reanimus
Copy link
Contributor

@reanimus reanimus commented Sep 9, 2019 •
edited
Loading

Motivation for this change

Fixes bugs with apps using newer versions of openssl. Fixes #68320

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Sorry, something went wrong.

@reanimus
Update trousers to latest, use regular openssl

Verified

This commit was signed with the committer’s verified signature.
nolmoonen Nol Moonen
GPG key ID: 486F753FC25B6289
Verified
Learn about vigilant mode
15629b1
@lheckemann lheckemann modified the milestones: 20.03, 19.09 Sep 10, 2019
@c0bw3b c0bw3b self-assigned this Nov 11, 2019
@c0bw3b
trousers: cleanup
76783bd 
* some CFLAGS and LDFLAGS are not needed anymore

* libtool file fixup was a no-op

* license is now BSD-3 since:
https://sourceforge.net/p/trousers/trousers/ci/0160d229f8fbab7c6900662155f42050e3d563a0/
@c0bw3b c0bw3b added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 11, 2019
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 11, 2019

@GrahamcOfBorg build simpleTpmPk11 opencryptoki tboot tpm-tools

c0bw3b
c0bw3b approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 68338 1

3 package are marked as broken and were skipped:
  • chaps
  • gnutls-kdh
  • tlspool
11 package were build:
  • opencryptoki
  • pond
  • rkt
  • simpleTpmPk11
  • strongswanTNC
  • tboot
  • tpm-luks
  • tpm-quote-tools
  • tpm-tools
  • tpmmanager
  • trousers

@c0bw3b c0bw3b merged commit 82dfacc into NixOS:master Nov 11, 2019
c0bw3b pushed a commit that referenced this pull request Nov 11, 2019
@reanimus @c0bw3b
trousers: 0.3.13 -> 0.3.14
d493b97 
* Update trousers to latest, use regular openssl (#68338)

trousers: cleanup

* some CFLAGS and LDFLAGS are not needed anymore

* libtool file fixup was a no-op

* license is now BSD-3 since:
https://sourceforge.net/p/trousers/trousers/ci/0160d229f8fbab7c6900662155f42050e3d563a0/

(cherry picked from commit 82dfacc)
@c0bw3b c0bw3b added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 11, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 11, 2019
@reanimus @dtzWill
trousers: 0.3.13 -> 0.3.14
2ba8d1b 
* Update trousers to latest, use regular openssl (NixOS#68338)

trousers: cleanup

* some CFLAGS and LDFLAGS are not needed anymore

* libtool file fixup was a no-op

* license is now BSD-3 since:
https://sourceforge.net/p/trousers/trousers/ci/0160d229f8fbab7c6900662155f42050e3d563a0/

(cherry picked from commit 82dfacc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b

Assignees

@c0bw3b c0bw3b

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

segfault in simpleTpmPk11 during ssh
3 participants
@reanimus @c0bw3b @lheckemann