Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.MySQL_python: remove #68354

Merged
merged 1 commit into from Sep 9, 2019
Merged

python.pkgs.MySQL_python: remove #68354

merged 1 commit into from Sep 9, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 9, 2019

Reasons:

  • No release since 2014
  • deprecated by upstream
  • no longer compatible with newer libmysql versions
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
python.pkgs.MySQL_python: remove
4a53284 
Reasons:

- No release since 2014
- deprecated by upstream
- no longer compatible with newer libmysql versions
@Mic92 Mic92 requested a review from FRidh as a code owner September 9, 2019 12:19
@Mic92 Mic92 mentioned this pull request Sep 9, 2019
Merged
10 tasks
@Mic92
Copy link
Member Author

Mic92 commented Sep 9, 2019

Context is a mariadb upgrade: #65222

@Mic92
Copy link
Member Author

Mic92 commented Sep 9, 2019

The package dates back to times, when nixpkgs was still in SVN.

@Mic92 Mic92 merged commit 779cde2 into NixOS:master Sep 9, 2019
@Mic92 Mic92 deleted the remove-mysql-python branch September 9, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92