Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bingrep: 0.7.0 -> 0.8.1 #75576

Merged
merged 1 commit into from Dec 14, 2019
Merged

bingrep: 0.7.0 -> 0.8.1 #75576

merged 1 commit into from Dec 14, 2019

Conversation

c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented Dec 12, 2019

Motivation for this change

Pkg update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @minijackson

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable shows usage

[4 built, 1 copied, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75576
1 package were built:
bingrep

@jonringer jonringer merged commit 637f16d into NixOS:master Dec 14, 2019
@minijackson
Copy link
Member

Thank you!

@c0bw3b c0bw3b deleted the pkg/bingrep branch December 14, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants