emacsMacport: Rename emacsVersion attribute to version #75618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsamsa
force-pushed
the
emacsmacport-fix
branch
from
88ca819
to
7889166
Compare
jsamsa
changed the title
|
@GrahamcOfBorg build emacsMacport |
|
Here is the error produced before the fix: error: attribute 'version' missing, at /nix/store/dd3rda2yhmn8qdmpdwz4kqwfh5h8af2w-nixpkgs-20.03pre204216.cc6cf0a96a6/nixpkgs/pkgs/applications/editors/emacs-modes/elpa-packages.nix:43:35 |
adisbladis
requested changes
Dec 13, 2019
Changes in NixOS#74936 depend on emacs derivations to have a version attribute.
jsamsa
force-pushed
the
emacsmacport-fix
branch
from
7889166
to
77804ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #74936 depend on emacs
derivations to have a version attribute.
Motivation for this change
change in #74936 reference "version" attribute in emacs derivations. emacsMacport used "emacsVersion". I found no other references to "emacsVersion" throughout nixpkgs and chose to change the derivation to use version which is in line with the reference found in elpa-packages.nix.
Bug can be reproduced/tested in the repl like so:
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @jwiegley @matthewbauer