Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http egg cve fix #75562

Merged
merged 4 commits into from Dec 13, 2019
Merged

Http egg cve fix #75562

merged 4 commits into from Dec 13, 2019

Conversation

corngood
Copy link
Contributor

Motivation for this change

Fix evaluation of all chicken-scheme packages, and fix #73650.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@corngood corngood mentioned this pull request Dec 13, 2019
Closed
1 task
c0bw3b
c0bw3b approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 75562 1

1 package were build:
  • egg2nix

@c0bw3b c0bw3b merged commit af5547f into NixOS:master Dec 13, 2019
@marsam
Copy link
Contributor

marsam commented Dec 13, 2019 •
edited

@corngood good work, thanks!
by any chance, would you be interested in adding yourself as maintainer of chicken?

@c0bw3b c0bw3b mentioned this pull request Dec 14, 2019
Merged
10 tasks
@corngood
Copy link
Contributor Author

@marsam yeah, sure. see #76076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability roundup 77: http-client-0.6.4: 1 advisory
3 participants
@corngood @marsam @c0bw3b