Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hivemind: 1.0.4 -> 1.0.6 #75567

Merged
merged 1 commit into from Dec 14, 2019
Merged

hivemind: 1.0.4 -> 1.0.6 #75567

merged 1 commit into from Dec 14, 2019

Conversation

duijf
Copy link
Contributor

@duijf duijf commented Dec 12, 2019 •
edited

Motivation for this change

The hivemind application has a new version. Changelog excerpt:

Build the new version with: nix-build -A hivemind

v1.0.6
Critical fix for Linux

v1.0.5
Loading environment variables from .env file;
Hivemind options can be set with environment variables;
--no-prefix flag.

Build the new version with: nix-build -A hivemind

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sveitser

@ofborg ofborg bot requested a review from ehmry December 12, 2019 16:42
ruuda
ruuda approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@ruuda ruuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the package and tested running an application with it on non-NixOS.

@sveitser
Copy link
Contributor

Build and runs fine for me on NixOS. LGTM.

jonringer
jonringer approved these changes Dec 14, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
executable shows usage

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/75567
1 package were built:
hivemind

@jonringer
Copy link
Contributor

@GrahamcOfBorg build hivemind

@jonringer jonringer merged commit 88c6f13 into NixOS:master Dec 14, 2019
@duijf duijf deleted the hivemind-v1.0.6 branch December 14, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruuda ruuda ruuda approved these changes

@jonringer jonringer jonringer approved these changes

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@duijf @sveitser @jonringer @ruuda