Skip to content

step-ca: init at 0.13.3 #75548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2020
Merged

step-ca: init at 0.13.3 #75548

merged 1 commit into from
Jan 3, 2020
+318 −0

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Dec 12, 2019 •
edited
Loading

Motivation for this change

This adds step-ca, a certificate server that goes along with step-cli. This is already available in nixpkgs: https://github.com/NixOS/nixpkgs/tree/master/pkgs/tools/security/step-cli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @xfix

Sorry, something went wrong.

@CMCDragonkai
Copy link
Member Author

Note that the next prerelease stops using deps and uses go 2 modules. So will require a better deps generator.

@CMCDragonkai
Copy link
Member Author

Should this be put into pkgs/servers instead?

@CMCDragonkai
Copy link
Member Author

This should be ready to go.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Dec 12, 2019
@ofborg ofborg bot requested a review from ehmry December 12, 2019 05:04
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 12, 2019
@CMCDragonkai
step-ca: init at 0.13.3

Verified

This commit was signed with the committer’s verified signature. The key has expired.
marsam Mario Rodas
GPG key ID: 4C4BEFD7B18DC5E8
Expired
Verified
Learn about vigilant mode
84163bf
@CMCDragonkai
Copy link
Member Author

Ready to go if people feel that step-ca is in the right place.

@CMCDragonkai CMCDragonkai requested a review from c0bw3b December 16, 2019 02:27
@CMCDragonkai
Copy link
Member Author

Status update?

@CMCDragonkai
Copy link
Member Author

@c0bw3b

c0bw3b
c0bw3b approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon, I'm just coming back from some holidays :)

@c0bw3b c0bw3b merged commit af2046d into NixOS:master Jan 3, 2020
@CMCDragonkai CMCDragonkai deleted the step-ca branch January 9, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b

@ehmry ehmry

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CMCDragonkai @c0bw3b