Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.send2trash: fix hash #75538

Merged
merged 1 commit into from Dec 12, 2019
Merged

pythonPackages.send2trash: fix hash #75538

merged 1 commit into from Dec 12, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Dec 12, 2019

Motivation for this change

Fixes #75514

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Dec 12, 2019

@GrahamcOfBorg build pythonPackages.send2trash

@marsam marsam added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 12, 2019
@jonringer
Copy link
Contributor

thanks, looks like I forgot to update hash. must have been working due to local cache. My bad

@jonringer jonringer merged commit 7825cde into NixOS:master Dec 12, 2019
jonringer
jonringer approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of borg was able to build ilt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python send2trash from unstable should be 1.5.0 but it 1.4.2 in fact
2 participants
@marsam @jonringer