Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 324be1e1588b
Choose a base ref
...
head repository: ngscopeclient/scopehal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0c940dcdcfad
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Dec 13, 2019

  1. Added fallthrough comments to silence GCC warnings for deliberate fal… 

    …lthrough
    @azonenberg
    azonenberg committed Dec 13, 2019
    Copy the full SHA
    0c940dc View commit details
Showing with 6 additions and 0 deletions.
  1. +6 −0 scopehal/base64.cpp
6 changes: 6 additions & 0 deletions scopehal/base64.cpp
View file
Original file line number Diff line number Diff line change
@@ -45,6 +45,8 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
fragment = (char)base64_decode_value(*codechar++);
} while (fragment < 0);
*plainchar = (fragment & 0x03f) << 2;

//fall through
case step_b:
do {
if (codechar == code_in+length_in)
@@ -57,6 +59,8 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
} while (fragment < 0);
*plainchar++ |= (fragment & 0x030) >> 4;
*plainchar = (fragment & 0x00f) << 4;

//fall through
case step_c:
do {
if (codechar == code_in+length_in)
@@ -69,6 +73,8 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
} while (fragment < 0);
*plainchar++ |= (fragment & 0x03c) >> 2;
*plainchar = (fragment & 0x003) << 6;

//fall through
case step_d:
do {
if (codechar == code_in+length_in)