Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jd-gui: 1.4.0 -> 1.6.5 #75546

Merged
merged 1 commit into from Dec 14, 2019
Merged

jd-gui: 1.4.0 -> 1.6.5 #75546

merged 1 commit into from Dec 14, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change

Automatic update fails, upstream updated the build process, and got rid of a gradle 2 dependency in the process.
According to #58528 (comment) this could mean gradle_2 can be removed (And probably 3 as well).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@liff
Copy link
Contributor

liff commented Dec 13, 2019

Built and tested, works as expected.

@averelld averelld force-pushed the jdgui-update branch 2 times, most recently from 9428340 to dbdee74 Compare December 13, 2019 16:58

outputHashAlgo = "sha256";
outputHashMode = "flat";
outputHash = "16wh7cmkhi305i3x3l8qkmcy9z9l67q3rqaxdsy96gih9gbmmzb5";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit flacky. Does it not break the checksum, when a new javac changes the way the byte code is compiled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunately. Everything is back to the old approach.

@averelld averelld mentioned this pull request Dec 13, 2019
10 tasks
@Mic92 Mic92 merged commit fbfd77b into NixOS:master Dec 14, 2019
@ghost ghost mentioned this pull request Jan 10, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants