nixos/nginx/gitweb: add some (crucial) options #75602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Dec 14, 2019
flokli
reviewed
Dec 14, 2019
|
LGTM. Could you squash the 3 commits together into 1? Also, it'd be nice if you could add a NixOS test, so we could ensure things keep working ;-) |
|
ping @vanyaklimenko |
This replaces some hardcoded values in nginx's VirtualHosts's configuration with customizable options. Previous values are kept as default, so nothing should break for existing users. Co-Authored-By: Florian Klink <flokli@flokli.de>
ksixty
force-pushed
the
nginx-gitweb-more-options
branch
from
dbdb3a3
to
ed52a65
Compare
|
@vanyaklimenko NixOS tests are always nice for modules as at bare minimum it gives committers who have no domain specific knowledge of a module a better indication they aren't breaking anything by hitting 'merge'. That being said, this module doesn't currently have a test and as your PR mentions these are crucial options. If anyone has a chance to come back to this and create a NixOS test full bonus points will be awarded 🎉 Merging based on the code seeming reasonable to myself and @flokli as well as testing provided by @gnidorah. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This replaces some hardcoded values in nginx's VirtualHosts's configuration with customizable options. Previous values are kept as default, so nothing should break for existing users.
Call it a minimal refactoring.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @gnidorah