Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgpod: drop pygobject2 #75555

Merged
merged 2 commits into from Dec 17, 2019
Merged

libgpod: drop pygobject2 #75555

merged 2 commits into from Dec 17, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Dec 12, 2019 •
edited

Motivation for this change

Let's drop libgpod using pygobject2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added this to To do in Picking up garbage via automation Dec 12, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Dec 12, 2019

Weird, they still have the pygobject2 import in the code:

https://github.com/gpodder/gpodder/blob/30586eb29cb42b6aad33deeb9ef8370deff37af9/src/gpodder/sync.py#L47

@worldofpeace
libgpod: drop pygobject2
b3fd4fc 
Multi-output as well.
@worldofpeace
gpodder: drop ipod support
d206f31 
Upstream claims it doesn't work gpodder/gpodder#706.
@worldofpeace worldofpeace changed the title libgpod: drop python2 libgpod: drop pygobject2 Dec 12, 2019
@worldofpeace worldofpeace merged commit 6ea98c1 into NixOS:master Dec 17, 2019
Picking up garbage automation moved this from To do to Done Dec 17, 2019
@worldofpeace worldofpeace deleted the libgpod-python2-byehun branch December 17, 2019 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @jonringer